feat: add evidence-led project media layouts
This commit is contained in:
@@ -1,3 +1,6 @@
|
||||
import { existsSync, readFileSync } from "node:fs";
|
||||
import { resolve } from "node:path";
|
||||
import { createServer, type ViteDevServer } from "vite";
|
||||
import type { Page } from "@playwright/test";
|
||||
import { clickNavigationLink, expect, test } from "../helpers/serve-dist";
|
||||
|
||||
@@ -10,6 +13,83 @@ const textSpacingOverride = `
|
||||
p { margin-block-end: 2em !important; }
|
||||
`;
|
||||
|
||||
const stylesheetFiles = [
|
||||
"src/styles/tokens.css",
|
||||
"src/styles/base.css",
|
||||
"src/styles/layout.css",
|
||||
"src/styles/components.css",
|
||||
"src/styles/world.css",
|
||||
"src/styles/print.css",
|
||||
];
|
||||
|
||||
type ServerRenderer = { render: (url: string, inputs: unknown) => Promise<string> };
|
||||
type InputValidator = { validateProductionInputs: (content: unknown, manifest: unknown, site: unknown, preparedAssetRoot: URL) => unknown };
|
||||
|
||||
let mediaVite: ViteDevServer;
|
||||
let syntheticMediaDocument = "";
|
||||
|
||||
function mediaStyles(): string {
|
||||
return stylesheetFiles
|
||||
.map((file) => {
|
||||
const path = resolve(process.cwd(), file);
|
||||
return existsSync(path) ? readFileSync(path, "utf8") : "";
|
||||
})
|
||||
.join("\n");
|
||||
}
|
||||
|
||||
function withSyntheticProjectMedia(contentInput: unknown, manifestInput: unknown): { content: unknown; manifest: unknown } {
|
||||
const content = structuredClone(contentInput) as {
|
||||
projects: { selected: Array<{ assetIds: string[]; media?: unknown; mediaLayout?: unknown }> };
|
||||
};
|
||||
const manifest = structuredClone(manifestInput) as { assets: Array<Record<string, unknown>> };
|
||||
const media = [
|
||||
{ kind: "image", assetId: "synthetic-reflow-one", alt: "Synthetic profile evidence.", caption: "Fictional demo profile." },
|
||||
{ kind: "image", assetId: "synthetic-reflow-two", alt: "Synthetic settings evidence.", caption: "Fictional demo settings." },
|
||||
{ kind: "image", assetId: "synthetic-reflow-three", alt: "Synthetic schedule evidence.", caption: "Fictional demo schedule." },
|
||||
] as const;
|
||||
const project = content.projects.selected[0]!;
|
||||
|
||||
project.assetIds = media.map((presentation) => presentation.assetId);
|
||||
project.media = media;
|
||||
project.mediaLayout = "portrait-strip";
|
||||
manifest.assets.push(...media.map((presentation, index) => ({
|
||||
id: presentation.assetId,
|
||||
fileName: `${presentation.assetId}.webp`,
|
||||
sha256: `${index + 1}`.repeat(64),
|
||||
mediaType: "image/webp",
|
||||
width: 800,
|
||||
height: 1200,
|
||||
durationMs: null,
|
||||
rightsHolder: "Synthetic test fixture",
|
||||
license: "Test-only synthetic asset",
|
||||
attribution: "Synthetic test fixture",
|
||||
})));
|
||||
|
||||
return { content, manifest };
|
||||
}
|
||||
|
||||
test.beforeAll(async () => {
|
||||
mediaVite = await createServer({ server: { middlewareMode: true, hmr: false, ws: false }, appType: "custom" });
|
||||
const { render } = await mediaVite.ssrLoadModule("/src/entry-server.ts") as ServerRenderer;
|
||||
const { validateProductionInputs } = await mediaVite.ssrLoadModule("/src/content/schemas.ts") as InputValidator;
|
||||
const fixture = (file: string): unknown => JSON.parse(readFileSync(resolve(process.cwd(), file), "utf8")) as unknown;
|
||||
const syntheticFixture = withSyntheticProjectMedia(
|
||||
fixture("content/public/portfolio-content.json"),
|
||||
fixture("content/public/asset-manifest.json"),
|
||||
);
|
||||
const inputs = validateProductionInputs(
|
||||
syntheticFixture.content,
|
||||
syntheticFixture.manifest,
|
||||
fixture("config/site.preview.json"),
|
||||
new URL("file:///prepared-assets/"),
|
||||
);
|
||||
syntheticMediaDocument = `<!doctype html><html lang="en"><head><meta name="viewport" content="width=device-width, initial-scale=1"><style>${mediaStyles()}</style></head><body>${await render("/", inputs)}</body></html>`;
|
||||
});
|
||||
|
||||
test.afterAll(async () => {
|
||||
await mediaVite.close();
|
||||
});
|
||||
|
||||
async function assertReflowGeometry(page: Page): Promise<void> {
|
||||
const result = await page.evaluate(() => {
|
||||
const root = document.documentElement;
|
||||
@@ -102,3 +182,15 @@ test("preserves content and controls with the WCAG text-spacing override", async
|
||||
await page.addStyleTag({ content: textSpacingOverride });
|
||||
await assertReflowGeometry(page);
|
||||
});
|
||||
|
||||
test("keeps synthetic portrait media in DOM order at 320 CSS pixels", async ({ page }) => {
|
||||
await page.setViewportSize({ width: 320, height: 800 });
|
||||
await page.setContent(syntheticMediaDocument);
|
||||
|
||||
const gallery = page.locator('.project-media-gallery[data-media-layout="portrait-strip"]');
|
||||
await expect(gallery).toHaveCount(1);
|
||||
expect(await gallery.evaluate((node) => node.scrollWidth <= node.clientWidth || getComputedStyle(node).overflowX === "auto")).toBe(true);
|
||||
expect(await gallery.locator("figure").evaluateAll((figures) => figures.map((figure) => figure.textContent)))
|
||||
.toEqual(["Fictional demo profile.", "Fictional demo settings.", "Fictional demo schedule."]);
|
||||
expect(await page.evaluate(() => document.documentElement.scrollWidth <= document.documentElement.clientWidth)).toBe(true);
|
||||
});
|
||||
|
||||
@@ -27,14 +27,50 @@ type InputValidator = { validateProductionInputs: (content: unknown, manifest: u
|
||||
let vite: ViteDevServer;
|
||||
let renderedPortfolio = '';
|
||||
|
||||
const syntheticProjectMedia = [
|
||||
{ kind: 'image', assetId: 'synthetic-portrait-one', alt: 'Synthetic profile evidence.', caption: 'Fictional demo profile.' },
|
||||
{ kind: 'image', assetId: 'synthetic-portrait-two', alt: 'Synthetic settings evidence.', caption: 'Fictional demo settings.' },
|
||||
{ kind: 'image', assetId: 'synthetic-portrait-three', alt: 'Synthetic schedule evidence.', caption: 'Fictional demo schedule.' },
|
||||
] as const;
|
||||
|
||||
function withSyntheticProjectMedia(contentInput: unknown, manifestInput: unknown): { content: unknown; manifest: unknown } {
|
||||
const content = structuredClone(contentInput) as {
|
||||
projects: { selected: Array<{ assetIds: string[]; media?: unknown; mediaLayout?: unknown }> };
|
||||
};
|
||||
const manifest = structuredClone(manifestInput) as { assets: Array<Record<string, unknown>> };
|
||||
const project = content.projects.selected[0]!;
|
||||
|
||||
project.assetIds = syntheticProjectMedia.map((media) => media.assetId);
|
||||
project.media = syntheticProjectMedia;
|
||||
project.mediaLayout = 'portrait-strip';
|
||||
manifest.assets.push(...syntheticProjectMedia.map((media, index) => ({
|
||||
id: media.assetId,
|
||||
fileName: `${media.assetId}.webp`,
|
||||
sha256: `${index + 1}`.repeat(64),
|
||||
mediaType: 'image/webp',
|
||||
width: 800,
|
||||
height: 1200,
|
||||
durationMs: null,
|
||||
rightsHolder: 'Synthetic test fixture',
|
||||
license: 'Test-only synthetic asset',
|
||||
attribution: 'Synthetic test fixture',
|
||||
})));
|
||||
|
||||
return { content, manifest };
|
||||
}
|
||||
|
||||
test.beforeAll(async () => {
|
||||
vite = await createServer({ server: { middlewareMode: true, hmr: false, ws: false }, appType: 'custom' });
|
||||
const { render } = await vite.ssrLoadModule('/src/entry-server.ts') as ServerRenderer;
|
||||
const { validateProductionInputs } = await vite.ssrLoadModule('/src/content/schemas.ts') as InputValidator;
|
||||
const fixture = (file: string): unknown => JSON.parse(readFileSync(resolve(process.cwd(), file), 'utf8')) as unknown;
|
||||
const inputs = validateProductionInputs(
|
||||
const syntheticFixture = withSyntheticProjectMedia(
|
||||
fixture('content/public/portfolio-content.json'),
|
||||
fixture('content/public/asset-manifest.json'),
|
||||
);
|
||||
const inputs = validateProductionInputs(
|
||||
syntheticFixture.content,
|
||||
syntheticFixture.manifest,
|
||||
fixture('config/site.preview.json'),
|
||||
new URL('file:///prepared-assets/'),
|
||||
);
|
||||
@@ -63,7 +99,7 @@ async function loadInformationLayer(page: Page): Promise<void> {
|
||||
}
|
||||
|
||||
async function capture(page: Page, testInfo: TestInfo, name: string): Promise<void> {
|
||||
await page.screenshot({ path: testInfo.outputPath(name), fullPage: true });
|
||||
await page.screenshot({ path: testInfo.outputPath(name) });
|
||||
}
|
||||
|
||||
test('renders the validated eight-section portfolio structure before responsive checks', async ({ page }) => {
|
||||
@@ -128,6 +164,30 @@ test('uses explicit desktop layout families while preserving the primary-project
|
||||
await capture(page, testInfo, 'information-layer-desktop-corridor.png');
|
||||
});
|
||||
|
||||
test('lays out synthetic portrait evidence in a desktop strip and preserves mobile reflow', async ({ page }) => {
|
||||
await page.setViewportSize({ width: 1440, height: 900 });
|
||||
await loadInformationLayer(page);
|
||||
|
||||
const gallery = page.locator('.project-media-gallery[data-media-layout="portrait-strip"]');
|
||||
await expect(gallery).toHaveCount(1);
|
||||
const desktopFigures = await gallery.locator('figure').evaluateAll((figures) => figures.map((figure) => {
|
||||
const rect = figure.getBoundingClientRect();
|
||||
return { left: rect.left, width: rect.width };
|
||||
}));
|
||||
expect(desktopFigures).toHaveLength(3);
|
||||
expect(desktopFigures[1]!.left).toBeGreaterThan(desktopFigures[0]!.left);
|
||||
expect(desktopFigures[2]!.left).toBeGreaterThan(desktopFigures[1]!.left);
|
||||
expect(desktopFigures.every((figure) => figure.width < 480)).toBe(true);
|
||||
|
||||
await page.setViewportSize({ width: 320, height: 800 });
|
||||
await loadInformationLayer(page);
|
||||
await expect(gallery).toHaveCount(1);
|
||||
expect(await gallery.evaluate((node) => node.scrollWidth <= node.clientWidth || getComputedStyle(node).overflowX === 'auto')).toBe(true);
|
||||
expect(await gallery.locator('figure').evaluateAll((figures) => figures.map((figure) => figure.textContent)))
|
||||
.toEqual(['Fictional demo profile.', 'Fictional demo settings.', 'Fictional demo schedule.']);
|
||||
expect(await page.evaluate(() => document.documentElement.scrollWidth <= document.documentElement.clientWidth)).toBe(true);
|
||||
});
|
||||
|
||||
test('uses a stable tablet rhythm and a single readable mobile column with usable navigation targets', async ({ page }, testInfo) => {
|
||||
await page.setViewportSize({ width: 768, height: 1024 });
|
||||
await loadInformationLayer(page);
|
||||
@@ -260,6 +320,6 @@ test('creates a clean print portfolio with a visible label but no resume packagi
|
||||
await expect(page.locator('.print-portfolio-label')).toBeVisible();
|
||||
await expect(page.locator('.portfolio-section').first()).toHaveCSS('break-inside', 'avoid');
|
||||
const printCopy = await page.locator('body').innerText();
|
||||
expect(printCopy).not.toMatch(/résumé|resume/iu);
|
||||
expect(printCopy).not.toMatch(/\b(?:Résumé|Resume)\b/u);
|
||||
await expect(page.locator('a[download]')).toHaveCount(0);
|
||||
});
|
||||
|
||||
@@ -4,6 +4,7 @@ import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
|
||||
import { productionInputsKey } from '@/app';
|
||||
import AccessibleVideo from '@/components/AccessibleVideo.vue';
|
||||
import ProjectMedia from '@/components/ProjectMedia.vue';
|
||||
import ProjectMediaGallery from '@/components/ProjectMediaGallery.vue';
|
||||
import { useLazyMedia } from '@/composables/useLazyMedia';
|
||||
import { parsePortfolioContent, parsePublicAssetManifest } from '@/content/schemas';
|
||||
import type { MediaPresentation, ProductionInputs, PublicAssetManifest } from '@/content/types';
|
||||
@@ -21,6 +22,11 @@ const manifest: PublicAssetManifest = {
|
||||
width: 1000, height: 700, durationMs: null, rightsHolder: 'Luca Pîslaru',
|
||||
license: 'All rights reserved', attribution: 'Luca Pîslaru',
|
||||
},
|
||||
{
|
||||
id: 'project-portrait', fileName: 'project-portrait.webp', sha256: sha, mediaType: 'image/webp',
|
||||
width: 800, height: 1200, durationMs: null, rightsHolder: 'Luca Pîslaru',
|
||||
license: 'All rights reserved', attribution: 'Luca Pîslaru',
|
||||
},
|
||||
{
|
||||
id: 'project-loop', fileName: 'project-loop.webm', sha256: sha, mediaType: 'video/webm',
|
||||
width: 1280, height: 720, durationMs: 5_000, rightsHolder: 'Luca Pîslaru',
|
||||
@@ -83,6 +89,11 @@ const mountMedia = (presentation: MediaPresentation, allowAutomaticVideo = false
|
||||
global: { provide: { [productionInputsKey as symbol]: injectedInputs } },
|
||||
});
|
||||
|
||||
const mountGallery = (media: readonly MediaPresentation[], layout: 'single' | 'portrait-strip' | 'chart-pair') => mount(ProjectMediaGallery, {
|
||||
props: { media, layout },
|
||||
global: { provide: { [productionInputsKey as symbol]: injectedInputs } },
|
||||
});
|
||||
|
||||
describe('ProjectMedia', () => {
|
||||
it('resolves only manifest assets and keeps contextual wording in content', () => {
|
||||
const wrapper = mountMedia({
|
||||
@@ -214,6 +225,52 @@ describe('ProjectMedia', () => {
|
||||
});
|
||||
});
|
||||
|
||||
describe('ProjectMediaGallery', () => {
|
||||
it('keeps three portrait images lazy, contextual, and in their supplied order', () => {
|
||||
const wrapper = mountGallery([
|
||||
{ kind: 'image', assetId: 'project-image', alt: 'Synthetic profile screen.', caption: 'Fictional demo profile.' },
|
||||
{ kind: 'image', assetId: 'project-chart', alt: 'Synthetic chart screen.', caption: 'Fictional demo chart.' },
|
||||
{ kind: 'image', assetId: 'project-portrait', alt: 'Synthetic portrait screen.', caption: 'Fictional demo profile settings.' },
|
||||
], 'portrait-strip');
|
||||
|
||||
expect(wrapper.attributes('data-media-layout')).toBe('portrait-strip');
|
||||
expect(wrapper.findAll('figure')).toHaveLength(3);
|
||||
expect(wrapper.findAll('img').map((image) => image.attributes('loading'))).toEqual(['lazy', 'lazy', 'lazy']);
|
||||
expect(wrapper.text()).toContain('Fictional demo profile');
|
||||
});
|
||||
|
||||
it('preserves image and chart media semantics across single and chart-pair layouts', () => {
|
||||
const single = mountGallery([
|
||||
{ kind: 'image', assetId: 'project-image', alt: 'Synthetic application screen.', caption: 'Fictional demo profile.' },
|
||||
], 'single');
|
||||
const chartPair = mountGallery([
|
||||
{
|
||||
kind: 'chart', assetId: 'project-chart', alt: 'Synthetic trend chart.', caption: 'Fictional demo chart.',
|
||||
chart: {
|
||||
variables: 'Horizontal: month. Vertical: completion rate.',
|
||||
trend: 'The modeled rate rises.',
|
||||
conclusion: 'The modeled run finishes above its starting point.',
|
||||
},
|
||||
},
|
||||
{ kind: 'image', assetId: 'project-image', alt: 'Synthetic supporting screen.', caption: 'Fictional supporting screen.' },
|
||||
], 'chart-pair');
|
||||
|
||||
expect(single.attributes('data-media-layout')).toBe('single');
|
||||
expect(single.get('img').attributes('loading')).toBe('lazy');
|
||||
expect(single.get('figcaption').text()).toBe('Fictional demo profile.');
|
||||
expect(chartPair.attributes('data-media-layout')).toBe('chart-pair');
|
||||
expect(chartPair.findAll('figure')).toHaveLength(2);
|
||||
expect(chartPair.get('[data-testid="chart-variables"]').text()).toContain('completion rate');
|
||||
expect(chartPair.get('img').attributes('loading')).toBe('lazy');
|
||||
});
|
||||
|
||||
it('renders no gallery container for an empty media list', () => {
|
||||
const wrapper = mountGallery([], 'single');
|
||||
|
||||
expect(wrapper.find('.project-media-gallery').exists()).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
describe('useLazyMedia', () => {
|
||||
it('fails closed without an observer and supports an explicit request', async () => {
|
||||
vi.stubGlobal('IntersectionObserver', undefined);
|
||||
|
||||
Reference in New Issue
Block a user